On May 24, 2014, at 9:18 AM, Michael Osipov <mosi...@gmx.de> wrote: > Hi, > > does it take special permissions on Github to process pull requests? > > Neither am I allowed to perform the merge from the website directly, nor does > it display the command line steps as described in the GH help. Close is not > available to me too. > > I simply pulled (PL 14) into my local repo and then pushed, asfgit processed > but the PL is still on "merged" but not closed. > > Is there any writeup how a PL should happen in the project? > Maven Git Convention [1] does not provide any valueable information.
If it doesn’t auto close for whatever reason (likely a rebase or something), then you would need to put a comment on the pull request like: Can you verify that the functionality ha been merged correctly and close this if it has. or similar to get the requestor to close it. OR Make a simple commit with: This closes #14 in the log message and the asf bot will close it. OR File a request with INFRA to close it. In general, if you pull a pull request and it ends up rebating or similar so the sha1 is different, then you should likely do a “git -a —amend” and edit the commit message to to add the “This closes #XX” line to the message before you push. -- Daniel Kulp dk...@apache.org - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
