Am Sat, 24 May 2014 19:06:24 +0200 schrieb Michael Osipov <micha...@apache.org>:
> Am 2014-05-24 18:57, schrieb Igor Fedorenko: > > Please don't use Github PL merge functionality. This will create > > merge commits... and I seriously dislike merge commits, hate them, > > actually. > > Are you able to share your experience by improving the Git Convention > on the Maven website? Me and others want a patch merged and not > fiddling with Git issues actually. I agree, that the merge button has some limitations. It encourages commits without running local checks before (unless you set up a CI to check-build PRs automatically). And, as already pointed out, it does not easily allow to rebase. But, using the merge button is not the only permission on a Github repo which would be good for commiters: beeing able to close a PR if it is rejected or merged differently and maintaining issues would be a good thing to be able. I am not sure if Infra actually wants to maintain single-developer-to-repo-role permissions. After all GitHub is regarded as a mirror not a primary workflow participant. I have currently a PR open (for commons) and I am not sure if I want to open a Infra ticket for it to be closed or not,thats why I am interested in this topic as well. Greeetings Bernd --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
