Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/105#issuecomment-141709744
Are we agree that the current PR is more about parameters than threading?
Before the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" were
sent without conversion to TestNG, but TestNG need `Integer`.
After the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" are
sent with conversion to TestNG, what it supposed to be done.
@dundacek already made [a fix](https://github.com/cbeust/testng/pull/798)
into TestNG for "-suitethreadpoolsize" but not for "-dataproviderthreadcount".
And I think we are all agree that TestNG is not the good place for that.
What I propose is to merge my fix because it has no risk
("-suitethreadpoolsize" and "-dataproviderthreadcount" are `Integer` since the
begginning) and it will help users, then we can try to improve parallel and/or
use the "new" TestNG method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
