Le jeudi 23 juin 2016 21:39:02 Robert Scholte a écrit : > >> > - move code to maven-shared-utils: the drawback here is to add jansi > >> > dependency to the artifact. > >> > >> That would pull in maven-shared-utils next to plexus-utils, which are > >> comparable and shouldn't be mixed due to classloading issues as seen in > >> the past. > > > > classloading issues between maven-shared-utils and plexus-utils? how can > > 2 > > separate pieces of code interfere? > > > >> > Any preference? Any other idea? > >> > >> So it seems like it should be a very small standalone module. It should > >> also pick up jansi from the classpath, jansi shouldn't be a direct > >> dependency, but a provided or optional one. > > > > hiding JAnsi will require more code, but looks feasible > > > > I'd really like to understand why maven-shared-utils would cause issues > > IIRC https://issues.apache.org/jira/browse/MNG-2892 is the key issue here. > However, nowadays plexus-utils is not shaded anymore, it is just another > dependency. Not sure where everything changed again, but I think it is > best that Maven uses plexus-utils, plugins use maven-shared-utils. > AFAIK M2.0.5 was a quite a bad release due to the usage of different > versions of plexus-utils between maven-core and the plugins. now, Plexus XPP3 classes are exposed through META-INF/maven/extensions.xml in maven-core
adding maven-shared-utils as a dependency won't make anything visible from plugins For the moment, I'll move code to maven-shared-utils: we'll see later if we want to move it further... Regards, Hervé --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
