>>MNG-6169 + local revert of clean gives: Not sure about your change (MNG-6169 + local revert of clean), but I know that The Clean Plugin 3.0.0 caused folder target/surefire-reports to be suddenly deleted. No report files found.
>> Yes but is this failing because of a regression in core or surefire? Regarding shouldNotBeVerbose(org.apache.maven.surefire.its.CheckTestNgReportTestIT) No regression or Maven and Surefire. Strange isn't it? The principle of this bug is that the POM in surefire-integration-tests module has property <testng.version>5.7</testng.version> So the IT runs Java process with this property, but the problem is that certain TestNG tests add the same property in CLI with version 5.10. The MavenLauncher has ArrayList<String> of these CLI goals. Duplicates are allowed in ArrayList. So the branch SUREFIRE_SYSPROP_DUPLICATES is hotfix and overrides old system property instead of duplicating them. Best would be to remove the aforementioned property in POM and amend 58 ITs. The hotfix was faster to do. Long explanation, but I would not judge Maven or Surefire regression. On Sat, Feb 18, 2017 at 6:38 PM, stephenconnolly [via Maven] < ml-node+s40175n5899153...@n5.nabble.com> wrote: > MNG-6169 + local revert of clean gives: > > Failed tests: > shouldNotBeVerbose(org.apache.maven.surefire.its.CheckTestNgReportTestIT): > > log pattern does not match nTimes(..) > > > testSkippedSurefireReportGeneration(org.apache.maven.surefire.its.jiras.Surefire772BothReportsIT): > > Expecting failsafe report file > > > testReportGeneration(org.apache.maven.surefire.its.jiras.Surefire772BothReportsIT): > > Expecting failsafe report file > > > testOptionalSurefireReportGeneration(org.apache.maven.surefire.its.jiras. > Surefire772NoSurefireReportsIT): > Expecting failsafe report file > > > testSkippedSurefireReportGeneration(org.apache.maven.surefire.its.jiras. > Surefire772NoSurefireReportsIT): > Expecting failsafe report file > > > testSkipOptionalSurefireReportGeneration(org.apache.maven. > surefire.its.jiras.Surefire772NoSurefireReportsIT): > Expecting failsafe report file > > > testReportGeneration(org.apache.maven.surefire.its.jiras. > Surefire772NoSurefireReportsIT): > Expecting failsafe report file > > > Tests run: 714, Failures: 7, Errors: 0, Skipped: 133 > > On 18 February 2017 at 17:36, Stephen Connolly < > [hidden email] <http:///user/SendEmail.jtp?type=node&node=5899153&i=0>> > wrote: > > > Yes but is this failing because of a regression in core or surefire? > > > > On 18 February 2017 at 17:32, Tibor Digana <[hidden email] > <http:///user/SendEmail.jtp?type=node&node=5899153&i=1>> wrote: > > > >> Hi Stephen, > >> > >> Both branches should be merged together. > >> SUREFIRE_SYSPROP_DUPLICATES > >> SUREFIRE_STDOUT_FLUSH > >> All tests should pass then. > >> Cheers > >> Tibor > >> > >> On Sat, Feb 18, 2017 at 6:21 PM, Tibor Digana-2 [via Maven] < > >> [hidden email] <http:///user/SendEmail.jtp?type=node&node=5899153&i=2>> > wrote: > >> > >> > We had this problem and the branch SUREFIRE_SYSPROP_DUPLICATES should > >> fix > >> > it. > >> > > >> > On Sat, Feb 18, 2017 at 6:12 PM, Stephen Connolly < > >> > [hidden email] <http:///user/SendEmail.jtp?type=node&node=5899136&i=0>> > > >> > wrote: > >> > > >> > > So Maven 3.5.0-SNAPSHOT just has one failure: > >> > > > >> > > > >> > > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 14.835 > >> > sec > >> > > <<< FAILURE! > >> > > > >> > > shouldNotBeVerbose(org.apache.maven.surefire.its.CheckTestNg > >> ReportTestIT) > >> > > >> > > Time elapsed: 0 sec <<< FAILURE! > >> > > > >> > > java.lang.AssertionError: log pattern does not match nTimes > >> > > > >> > > Expected: is <0> > >> > > > >> > > but: was <1> > >> > > > >> > > at org.hamcrest.MatcherAssert.ass > >> ertThat(MatcherAssert.java:20) > >> > > > >> > > at > >> > > org.apache.maven.surefire.its.fixture.OutputValidator.assert > >> ThatLogLine( > >> > > >> > > OutputValidator.java:104) > >> > > > >> > > at > >> > > org.apache.maven.surefire.its.CheckTestNgReportTestIT.should > >> NotBeVerbose( > >> > > >> > > CheckTestNgReportTestIT.java:55) > >> > > > >> > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > >> Method) > >> > > > >> > > at > >> > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce > >> ssorImpl.java: > >> > > >> > > 62) > >> > > > >> > > at > >> > > sun.reflect.DelegatingMethodAccessorImpl.invoke( > >> > > DelegatingMethodAccessorImpl.java:43) > >> > > > >> > > at java.lang.reflect.Method.invoke(Method.java:498) > >> > > > >> > > at > >> > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall( > >> > > FrameworkMethod.java:50) > >> > > > >> > > at > >> > > org.junit.internal.runners.model.ReflectiveCallable.run( > >> > > ReflectiveCallable.java:12) > >> > > > >> > > at > >> > > org.junit.runners.model.FrameworkMethod.invokeExplosively( > >> > > FrameworkMethod.java:47) > >> > > > >> > > at > >> > > org.junit.internal.runners.statements.InvokeMethod. > >> > > evaluate(InvokeMethod.java:17) > >> > > > >> > > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java: > > >> 325) > >> > > >> > > > >> > > at > >> > > org.junit.runners.BlockJUnit4ClassRunner.runChild( > >> > > BlockJUnit4ClassRunner.java:78) > >> > > > >> > > at > >> > > org.junit.runners.BlockJUnit4ClassRunner.runChild( > >> > > BlockJUnit4ClassRunner.java:57) > >> > > > >> > > at org.junit.runners.ParentRunner > >> $3.run(ParentRunner.java:290) > >> > > > >> > > at org.junit.runners.ParentRunner > >> $1.schedule(ParentRunner.java:71) > >> > > >> > > > >> > > at org.junit.runners.ParentRunner.runChildren( > >> > > ParentRunner.java:288) > >> > > > >> > > at org.junit.runners.ParentRunner > >> .access$000(ParentRunner.java:58) > >> > > >> > > > >> > > at org.junit.runners.ParentRunner$2.evaluate( > >> > > ParentRunner.java:268) > >> > > > >> > > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > > >> > > > >> > > at org.junit.runners.Suite.runChild(Suite.java:128) > >> > > > >> > > at org.junit.runners.Suite.runChild(Suite.java:27) > >> > > > >> > > at org.junit.runners.ParentRunner > >> $3.run(ParentRunner.java:290) > >> > > > >> > > at org.junit.runners.ParentRunner > >> $1.schedule(ParentRunner.java:71) > >> > > >> > > > >> > > at org.junit.runners.ParentRunner.runChildren( > >> > > ParentRunner.java:288) > >> > > > >> > > at org.junit.runners.ParentRunner > >> .access$000(ParentRunner.java:58) > >> > > >> > > > >> > > at org.junit.runners.ParentRunner$2.evaluate( > >> > > ParentRunner.java:268) > >> > > > >> > > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > > >> > > > >> > > at org.junit.runner.JUnitCore.run(JUnitCore.java:137) > >> > > > >> > > at org.junit.runner.JUnitCore.run(JUnitCore.java:115) > >> > > > >> > > at > >> > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper. > >> > > execute(JUnitCoreWrapper.java:62) > >> > > > >> > > at > >> > > org.apache.maven.surefire.junitcore.JUnitCoreProvider. > >> > > invoke(JUnitCoreProvider.java:139) > >> > > > >> > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > >> Method) > >> > > > >> > > at > >> > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce > >> ssorImpl.java: > >> > > >> > > 62) > >> > > > >> > > at > >> > > sun.reflect.DelegatingMethodAccessorImpl.invoke( > >> > > DelegatingMethodAccessorImpl.java:43) > >> > > > >> > > at java.lang.reflect.Method.invoke(Method.java:498) > >> > > > >> > > at > >> > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray( > > >> > > ReflectionUtils.java:189) > >> > > > >> > > at > >> > > org.apache.maven.surefire.booter.ProviderFactory$ProviderPro > >> xy.invoke( > >> > > ProviderFactory.java:165) > >> > > > >> > > at > >> > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider( > >> > > ProviderFactory.java:85) > >> > > > >> > > at > >> > > org.apache.maven.plugin.surefire.InPluginVMSurefireStarter. > >> > > runSuitesInProcess(InPluginVMSurefireStarter.java:80) > >> > > > >> > > at > >> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execut > >> eProvider( > >> > > AbstractSurefireMojo.java:724) > >> > > > >> > > at > >> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execut > >> eAllProviders( > >> > > >> > > AbstractSurefireMojo.java:682) > >> > > > >> > > at > >> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo. > >> > > executeAfterPreconditionsChecked(AbstractSurefireMojo.java:648) > >> > > > >> > > at > >> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo. > >> > > execute(AbstractSurefireMojo.java:586) > >> > > > >> > > at > >> > > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo( > >> > > DefaultBuildPluginManager.java:134) > >> > > > >> > > at > >> > > org.apache.maven.lifecycle.internal.MojoExecutor.execute( > >> > > MojoExecutor.java:207) > >> > > > >> > > at > >> > > org.apache.maven.lifecycle.internal.MojoExecutor.execute( > >> > > MojoExecutor.java:153) > >> > > > >> > > at > >> > > org.apache.maven.lifecycle.internal.MojoExecutor.execute( > >> > > MojoExecutor.java:145) > >> > > > >> > > at > >> > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b > >> uildProject( > >> > > >> > > LifecycleModuleBuilder.java:116) > >> > > > >> > > at > >> > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b > >> uildProject( > >> > > >> > > LifecycleModuleBuilder.java:80) > >> > > > >> > > at > >> > > org.apache.maven.lifecycle.internal.builder.singlethreaded. > >> > > SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > >> > > > >> > > at > >> > > org.apache.maven.lifecycle.internal.LifecycleStarter. > >> > > execute(LifecycleStarter.java:128) > >> > > > >> > > at org.apache.maven.DefaultMaven. > >> doExecute(DefaultMaven.java:309) > >> > > >> > > > >> > > at org.apache.maven.DefaultMaven. > >> doExecute(DefaultMaven.java:194) > >> > > >> > > > >> > > at org.apache.maven.DefaultMaven. > >> execute(DefaultMaven.java:107) > >> > > > >> > > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:907) > > >> > > > >> > > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:304) > >> > > > >> > > at org.apache.maven.cli.MavenCli.main(MavenCli.java:208) > >> > > > >> > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > >> Method) > >> > > > >> > > at > >> > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce > >> ssorImpl.java: > >> > > >> > > 62) > >> > > > >> > > at > >> > > sun.reflect.DelegatingMethodAccessorImpl.invoke( > >> > > DelegatingMethodAccessorImpl.java:43) > >> > > > >> > > at java.lang.reflect.Method.invoke(Method.java:498) > >> > > > >> > > at > >> > > org.codehaus.plexus.classworlds.launcher.Launcher. > >> > > launchEnhanced(Launcher.java:289) > >> > > > >> > > at > >> > > org.codehaus.plexus.classworlds.launcher.Launcher. > >> > > launch(Launcher.java:229) > >> > > > >> > > at > >> > > org.codehaus.plexus.classworlds.launcher.Launcher. > >> > > mainWithExitCode(Launcher.java:415) > >> > > > >> > > at > >> > > org.codehaus.plexus.classworlds.launcher.Launcher.main( > >> Launcher.java:356) > >> > > >> > > > >> > > > >> > > Running org.apache.maven.surefire.its.jiras.Surefire995CategoryInher > > >> itance > >> > > >> > > IT > >> > > > >> > > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 19.469 > >> > sec > >> > > > >> > > Running org.apache.maven.surefire.its.TestMultipleMethodPatternsTest > > >> NGIT > >> > > >> > > > >> > > Tests run: 90, Failures: 0, Errors: 0, Skipped: 41, Time elapsed: > >> > 190.874 > >> > > sec > >> > > > >> > > Running org.apache.maven.surefire.its.TestMultipleMethodPatternsIT > >> > > > >> > > Tests run: 180, Failures: 0, Errors: 0, Skipped: 87, Time elapsed: > >> > 359.579 > >> > > sec > >> > > > >> > > > >> > > Results : > >> > > > >> > > > >> > > Failed tests: > >> > > shouldNotBeVerbose(org.apache.maven.surefire.its.CheckTestNg > >> ReportTestIT): > >> > > >> > > log pattern does not match nTimes(..) > >> > > > >> > > > >> > > Tests run: 714, Failures: 1, Errors: 0, Skipped: 133 > >> > > > >> > > > >> > > > >> > > On 18 February 2017 at 16:19, Tibor Digana <[hidden email] > >> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=1>> > >> > > wrote: > >> > > > >> > > > I have downloaded Michaels log for Maven 3.3.9 & Surefire > >> > 2.19.2-SNAPSHOT > >> > > > http://home.apache.org/~michaelo/maven/surefire/maven- > >> > > > surefire-extended-patch-maven-3.3.9.tar.gz > >> > > > and 27 tests failed. > >> > > > > >> > > > > >> > > > On Sat, Feb 18, 2017 at 4:52 PM, Stephen Connolly < > >> > > > [hidden email] <http:///user/SendEmail.jtp?ty > >> pe=node&node=5899136&i=2>> > >> > wrote: > >> > > > > >> > > > > So results so far: surefire master branch builds with 3.3.9 but > >> > fails > >> > > > with > >> > > > > 3.5.0-SNAPSHOT when running on macOS Sierra with Oracle Java > >> > 1.8.0_121 > >> > > > > > >> > > > > That is certainly looking like a regression in Maven core > >> > > > > > >> > > > > On 18 February 2017 at 10:55, Michael Osipov <[hidden email] > >> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=3>> > >> > > > wrote: > >> > > > > > >> > > > > > For those who would like to reproduce the issues: > >> > > > > > > >> > > > > > 1. Build Maven distribution from 3.3.9, master, MNG-6169 and > >> > MNG-6169 > >> > > > > with > >> > > > > > locally modified maven-core/src/main/resources/ > >> > > > > META-INF/plexus/components.xml > >> > > > > > maven-clean-plugin 2.6.1 => 3.0.0. > >> > > > > > You should have four distros now. > >> > > > > > 2. Clone Surefire > >> > > > > > 3. Run all four versions of Maven against Surefire master: > >> > > > > > > ~/apache-maven-$version/bin/mvn -B -V clean install > >> > > > > > -Dinvoker.mergeSettings | tee ~/maven-surefire.log > >> > > > > > Leave mergeSettings out if you have direct Internet > connection > >> > > > > > 4. Save maven-surefire.log and surefire-integration-tests/tar > >> get > >> > for > >> > > > > > later analysis > >> > > > > > 5. Branch off Surefire master and apply branches: > >> > > > > > origin/SUREFIRE_STDOUT_FLUSH > >> > > > > > origin/SUREFIRE_SYSPROP_DUPLICATES > >> > > > > > 6. Repeat step 3 > >> > > > > > 7. Checkout maven-shared-utils-0.9.x from Subversion, install > >> and > >> > > > update > >> > > > > > maven-surefire/pom.xml with version 0.9.1-SNAPSHOT > >> > > > > > 8. Repeat 6 > >> > > > > > 7. Compare results of 3, 5, 6, 8 as well as with my > >> > > maven-surefire.log > >> > > > > > files > >> > > > > > > >> > > > > > note: my logs are based on an already patched version (from > >> > mentioned > >> > > > > > branches) of Surefire master. > >> > > > > > > >> > > > > > > >> > > > > > Michael > >> > > > > > > >> > > > > > ------------------------------------------------------------ > >> > > --------- > >> > > > > > To unsubscribe, e-mail: [hidden email] > >> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=4> > >> > > > > > For additional commands, e-mail: [hidden email] > >> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=5> > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > > -- > >> > > > Cheers > >> > > > Tibor > >> > > > > >> > > > >> > > >> > > >> > > >> > -- > >> > Cheers > >> > Tibor > >> > > >> > > >> > ------------------------------ > >> > If you reply to this email, your message will be added to the > discussion > >> > below: > >> > http://maven.40175.n5.nabble.com/Recent-issues-found-in- > >> > Surefire-master-Maven-Clean-Plugin-3-0-0-with-Maven- > >> > master-tp5898937p5899136.html > >> > To start a new topic under Maven Developers, email > >> > [hidden email] > <http:///user/SendEmail.jtp?type=node&node=5899153&i=3> > >> > To unsubscribe from Maven Developers, click here > >> > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?m > >> acro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYX > >> BhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==> > >> > . > >> > NAML > >> > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?m > >> acro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base > >> =nabble.naml.namespaces.BasicNamespace-nabble.view.web. > >> template.NabbleNamespace-nabble.view.web.template.NodeNamesp > >> ace&breadcrumbs=notify_subscribers%21nabble%3Aemail. > >> naml-instant_emails%21nabble%3Aemail.naml-send_instant_ > >> email%21nabble%3Aemail.naml> > >> > > >> > >> > >> > >> > >> -- > >> View this message in context: http://maven.40175.n5.nabble.c > >> om/Recent-issues-found-in-Surefire-master-Maven-Clean-Plugin > >> -3-0-0-with-Maven-master-tp5898937p5899138.html > >> Sent from the Maven Developers mailing list archive at Nabble.com. > > > > > > > > > ------------------------------ > If you reply to this email, your message will be added to the discussion > below: > http://maven.40175.n5.nabble.com/Recent-issues-found-in- > Surefire-master-Maven-Clean-Plugin-3-0-0-with-Maven- > master-tp5898937p5899153.html > To start a new topic under Maven Developers, email > ml-node+s40175n142166...@n5.nabble.com > To unsubscribe from Maven Developers, click here > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==> > . > NAML > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > -- View this message in context: http://maven.40175.n5.nabble.com/Recent-issues-found-in-Surefire-master-Maven-Clean-Plugin-3-0-0-with-Maven-master-tp5898937p5899164.html Sent from the Maven Developers mailing list archive at Nabble.com.
