[ http://jira.codehaus.org/browse/MNG-760?page=comments#action_44828 ]
Trygve Laugstol commented on MNG-760: ------------------------------------- A couple quick comments on a very good patch: * Please use the i18n component for internationalization stuff. Not sure if there are any other Mojos that's using it but the CLI in maven-core use it. * Please find a more descriptive name than "conclasspath". This parameter should also be a List, not a comma separated list. > m2 eclipse plugin improvements (source download and attachment, customization > of natures/builders/conclasspath, flexible project dupport) and refactoring > --------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: MNG-760 > URL: http://jira.codehaus.org/browse/MNG-760 > Project: Maven 2 > Type: Improvement > Components: maven-plugins > Versions: 2.0-beta-1 > Reporter: fabrizio giustina > Fix For: 2.0-beta-1 > Attachments: MNG-760.diff > > Original Estimate: 1 hour > Remaining: 1 hour > > This patch adds the following to the M2 eclipse plugin: > - downloading of source attachments and configuration in .classpath > - customization of project builders and natures in .project (like in the m1 > plugin) > - additional conclasspath entries in .classpath (like in the m1 plugin) > - fix: don't add duplicate directories if main/resources directories overlap > (like in the m1 plugin) > - support for flexible projects (.wtpmodules file generation for utility > modules, wars, ejbs) > Along with these new features the plugin has been refactored, splitting the > single big EclipseWriter class to several specific classes and all the > messages have been externalized in a property file. > There are still some todos in the code, which probably some M2 guru could > look at, but anyway all the existing functionalities continue to work and > some other tests have been added. > Due to the refactoring the patch looks more like a complete rewrite: sorry > for that, but adding new features without splitting the existing file was ugly -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
