Actually I missed that. Mark, what's the problem with analyze forking the build if there is already a justAnalyze that doesn't?
-----Original Message----- From: Max Bowsher [mailto:[EMAIL PROTECTED] Sent: Monday, September 17, 2007 12:13 PM To: Maven Developers List Subject: Re: dependency:analyze changes Mark Hobson wrote: > On 17/09/2007, Mark Hobson <[EMAIL PROTECTED]> wrote: >> On 17/09/2007, Mark Hobson <[EMAIL PROTECTED]> wrote: >>> Brian and anyone else interested, >>> >>> I'd like to make a couple of small changes to the analyze goal: >>> >>> 1) Remove @execute phase="test-compile" and replace with @phase >>> verify. This will allow it to be used in the verification phase in >>> a similar way to checkstyle et al. The explicit @execute behaviour >>> currently means that everything is compiled twice when bound to the >>> lifecycle like this. The original behaviour can still be achieve >>> with a mvn test-compile dependency:analyze. >>> >>> 2) Remove the call to analyze-dep-mgt from analyze - they should >>> really be distinct goals since they process different data. >>> >>> 3) Tidy up the analyze params and output. >> Forgot to add: >> >> 4) Remove JustAnalyze goal, since this will be redundant with (1). > > Okay, I'm going to commit these changes whilst I've got time to work > on them - we can always back them out if anyone seriously objects. > Too many local changes are hard to manage.. I'd like to argue against point (1). I think that quite a few people are used to typing "mvn dependency:analyze" by now, and changing it would introduce unnecessary confusion. I suggest following the pattern of the assembly plugin's "assembly:assembly" vs. "assembly:attached", i.e. keep the existing @execute behaviour, and add another name for the invoking the mojo without @execute behaviour. Max. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
