> I haven't had yet the time to setup some nice IT for this, but the fix is > here: MPLUGIN-101. great!
There is one feature in this patch I don't like: you hardcoded a default encoding to ISO-8859-1 instead of no default value (which means platform encoding). I understand that platform encoding is bad for reproducibility, and you avoid platform encoding with this default value: even if a developer wanted to configure platform encoding, he could not! But I don't think it is a good choice. Platform encoding is here to give most developers freedom to ignore encoding notions. And most of the time it works well. Every native tool use platform encoding by default, so do javac, javadoc, ant,... Having a default encoding is not consistent, and people not using ISO-8859-1 as their platform encoding won't understand the failure (or understand this is a complicated encoding problem caused by a bad tool). To help developers discover that relying on platform encoding is not a good choice, I think there are better ways than stopping the "magic" of it: - I just changed resources plugin with MRESOURCES-62 to be more explicit: > [INFO] [resources:resources] > [INFO] Using platform encoding (UTF-16 actually) to copy filtered resources. Now, developer knows he is using platform encoding, and he even know which one is used *actually*. Then setting a configuration is not a problem: just do it (no more question: "what is your platform encoding?") - perhaps there should be an enforcer rule to check that common plugins are configured with explicit encoding. - perhaps Maven itself should show the good habits: define a property in the parent pom and take care of properly declaring encoding for plugins regards, Hervé --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
