Re: Include maven-car-plugin to the official maven plugins

[Pablo]

Hi, In reply to Stephane: On 03/14/2011 04:22 PM, Stephane Nicoll wrote: Hi, I am currently working on supporting the "application-client" artifact type properly in the EAR plugin. Pablo (in CC) wrote a maven-car-plugin[1] which is very similar to the EJB plugin but for application-client type. Do we think it would be reasonable to add this plugin to the portfolio of standard plugins? (if Pablo accepts to contribute it to the ASF but I don't think it would be an issue). I am more than happy to donate the plugin to the ASF and to help in whichever way is needed. I am bit puzzled about the type 'car' since car is already used by Geronimo for their deployment plans; <type>application-client</type> would better fit I'd say (with a .jar extension) Yes, i think either  <type>application-client</type> or <type>app-client</type> would be fine. Probably more self explanatory than 'car'. And yesm once packaged, the file must have .jar extension, this is what app servers expect. We could then rename the plugin to maven-application-client-plugin or maven-app-client-plugin if that made it more clear. The problems I am having is that since we don't have an "official" maven type for that thing and nothing to build it with Maven, I can't detect these artifacts other than scanning every single jar file added to a project to see if there is a META-INF/application-client.xml file. Frankly, I am not going to implement a feature that will scan every single jar file before building an EAR I don't think scanning every jar is a good idea either, doesn't take much effor to add <type>app-client</type> in the ear's pom The plugin needs a bit of cleanup (namely the jEE version check) and I don't know if the community uses this a lot but we don't cover the whole spectrum of the JavaEE spec and it wouldn't cost us much to do it. I am sure it will not get as used as ejb, war or ear plugin but i think it will get more used than 'rar' . And yes, agree in the point that being defined in the JEE spec we should be implementing it. Can someone remind me how these "official" types gets added and detected by Maven? Do we absolutely need to touch the core type definition files or is there another way? To my knowledge, defining a packaging type and artifact handler inside a plugin (Meta-INF/plexus/components.xml) only makes it visible if you add the plugin as a dependency. This means that we would have to add maven-app-client-plugin as a dependency to maven-ear-plugin and the ear projects. No good. I vote for adding it to the core type definition files and give it the exact same status as rar,war,ejb,ear, etc. Please let me know what you think. Thanks, S. [1] http://code.google.com/p/maven-car-plugin --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Pablo Rodriguez Pina Director Anahata Technologies PTY LTD Phone 04 1091 5078 E-mail pa...@anahata-it.com Web anahata-it.com