Sorry, my misunderstanding. Looks good to me ;)
Kristian lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll: > What other code are you talking about? The plugin on google code? The idea > here is to deprecate it in favor of this "official" maven plugin > > S. > > On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold < > [email protected]> wrote: > > > Just out of curiosity, how does this code relate to the other code that > > does similar stuff? Is it a copy paste fork? > > > > Kristian > > > > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy: > > > Hi, > > > No problem for me if you want to add this new packaging support and > > > add in maven core. > > > > > > acr ? > > > > > > -- > > > Olivier > > > > > > 2011/3/19 Stephane Nicoll <[email protected]>: > > > > No Maven committers/PMCs replied to this. > > > > > > > > Any insight? > > > > > > > > S. > > > > > > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll > > > > <[email protected]>wrote: > > > > > > > >> Hi, > > > >> > > > >> I am currently working on supporting the "application-client" artifact > > > >> type properly in the EAR plugin. Pablo (in CC) wrote a > > > >> maven-car-plugin[1] which is very similar to the EJB plugin but for > > > >> application-client type. Do we think it would be reasonable to add > > > >> this plugin to the portfolio of standard plugins? (if Pablo accepts to > > > >> contribute it to the ASF but I don't think it would be an issue). > > > >> > > > >> I am bit puzzled about the type 'car' since car is already used by > > > >> Geronimo for their deployment plans; <type>application-client</type> > > > >> would better fit I'd say (with a .jar extension) > > > >> > > > >> The problems I am having is that since we don't have an "official" > > > >> maven type for that thing and nothing to build it with Maven, I can't > > > >> detect these artifacts other than scanning every single jar file added > > > >> to a project to see if there is a META-INF/application-client.xml > > > >> file. Frankly, I am not going to implement a feature that will scan > > > >> every single jar file before building an EAR > > > >> > > > >> The plugin needs a bit of cleanup (namely the jEE version check) and I > > > >> don't know if the community uses this a lot but we don't cover the > > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much to do > > > >> it. > > > >> > > > >> Can someone remind me how these "official" types gets added and > > > >> detected by Maven? Do we absolutely need to touch the core type > > > >> definition files or is there another way? > > > >> > > > >> Please let me know what you think. > > > >> > > > >> Thanks, > > > >> S. > > > >> > > > >> [1] http://code.google.com/p/maven-car-plugin > > > >> > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
