I removed readonly and required as attributes of @component (both in javadoc
or java 5 annotation form), since they are ignored by the descriptor
generation step (see r1339666)
I renamed "expression" to "property" for Java 5 annotations in r1339888.
Then I tried to add "property" support for javadoc tags, and found an un-
documented feature: property already exists in JavaMojoDescriptorExtractor
// ----------------------------------------------------------------------
// We will look for a property name here first and use that if present
// i.e:
//
// @parameter property="project"
//
// Which will become the name used for the configuration element which
// will in turn will allow plexus to use the corresponding setter.
// ----------------------------------------------------------------------
String property = parameter.getNamedParameter(
JavaMojoAnnotation.PARAMETER_PROPERTY );
if ( !StringUtils.isEmpty( property ) )
{
pd.setName( property );
}
else
{
pd.setName( entry.getKey() );
}
anybody knows? uses?
then property won't be a good choice to replace expression, we'll need a new
idea...
please comment
Regards,
Hervé
Le mardi 15 mai 2012 10:20:00 Brett Porter a écrit :
> I think these are both good ideas.
>
> There's a couple of things expression currently supports that probably
> shouldn't be supported under "property" to avoid confusion: - ${project.*}
> as these should be specified under a default-value (they can't be
> overridden by -Dproject.XXX, etc.). - ${settings}, ${session}, etc. - Maven
> internal variables. It would be good to have some other way to describe
> them that is not @parameter, and can avoid the need for the redundant
> @readonly and @required they usually come with
>
> Looking at that, it actually seems like readonly and required belong as
> attributes of @parameter now too.
>
> - Brett
>
> On 14/05/2012, at 5:59 AM, Hervé BOUTEMY wrote:
> > As discussed previously, there was some interest in changing supported
> > tags.
> >
> > Now that Java 5 annotations support is ok, I already added some change in
> > MPLUGIN-194 [1]: you can remove ${ } when defining parameter expression
> >
> > I just created MPLUGIN-196 issue [2] to rename "expression" to "property",
> > where ${ } would even not be supported
> >
> > Please comment: any objection? any better idea?
> >
> > Regards,
> >
> > Hervé
> >
> >
> > [1] https://jira.codehaus.org/browse/MPLUGIN-194
> >
> > [2] https://jira.codehaus.org/browse/MPLUGIN-196
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
> Brett Porter
> br...@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
> http://twitter.com/brettporter
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
