> On Aug. 12, 2013, 8:43 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp, line 12 > > <https://reviews.apache.org/r/13464/diff/4/?file=340073#file340073line12> > > > > Can this extend from stout hashmap? > > > > s/Map/map/
I looked into extending hashmap, but it is a bit complicated. I would have to override all modifying members of stout::hashmap and boost:unordered_map to ensure that link pointers are properly maintained. Why s/Map/map/ ? FWIW, I followed Java's convention for capitalization. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13464/#review25032 ----------------------------------------------------------- On Aug. 12, 2013, 5:49 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13464/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 5:49 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 0cd407cfbd3226ce610ef77cee3a16c0e198e144 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 770378d11d30e1e222e418c1839affd9d4ffe8d3 > 3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/13464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
