----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13464/#review25101 -----------------------------------------------------------
Ship it! Looks good, although there are a few things I find unfortunate: (1) Users will have to copy all keys / values if they want to iterate on the map. (2) LinkedHashMap and hashmap are incomatible (Different APIs w.r.t. to keys() and values()). (3) LinkedHashMap is not compatible with the map interface. I can take these on after this is committed if you would like to punt in the interest of finishing up slave recovery :) 3rdparty/libprocess/3rdparty/Makefile.am <https://reviews.apache.org/r/13464/#comment49314> alphabetical 3rdparty/libprocess/3rdparty/stout/Makefile.am <https://reviews.apache.org/r/13464/#comment49315> alphabetical 3rdparty/libprocess/3rdparty/stout/Makefile.am <https://reviews.apache.org/r/13464/#comment49316> alphabetical 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp <https://reviews.apache.org/r/13464/#comment49317> thanks! 3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp <https://reviews.apache.org/r/13464/#comment49320> It's ok not extending as well, so long as they are compatible :) Feel free to also assign this to me, the pedant in me will likely force me to make LinkedHashMap and hashmap compatible once this is committed. I'm ok with them being incompatible in the interest of unblocking you for your slave recovery changes :) - Ben Mahler On Aug. 13, 2013, 11:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13464/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 11:34 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 0cd407cfbd3226ce610ef77cee3a16c0e198e144 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > e465fd1b7c22a649a59e69a29c0c7f3e9198188b > 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp > 796cb505fe538d5f65c0f8ea1fa827155f2bb2c1 > 3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/13464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
