> On Aug. 14, 2013, 12:15 a.m., Ben Mahler wrote: > > Looks good, although there are a few things I find unfortunate: > > (1) Users will have to copy all keys / values if they want to iterate on > > the map. > > (2) LinkedHashMap and hashmap are incomatible (Different APIs w.r.t. to > > keys() and values()). > > (3) LinkedHashMap is not compatible with the map interface. > > > > I can take these on after this is committed if you would like to punt in > > the interest of finishing up slave recovery :)
added a TODO(vinod/bmahler) for one of us to take this up later. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13464/#review25101 ----------------------------------------------------------- On Aug. 13, 2013, 11:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13464/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 11:34 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 0cd407cfbd3226ce610ef77cee3a16c0e198e144 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > e465fd1b7c22a649a59e69a29c0c7f3e9198188b > 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp > 796cb505fe538d5f65c0f8ea1fa827155f2bb2c1 > 3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/13464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
