----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13868/#review25779 -----------------------------------------------------------
Each "issue" can be marked resolved or dropped, can you update them? (I really hate the word "issue" because it's pretty jarring for people, but the ability to track whether they were fixed or dropped is nice). Also, can you replace the usage of tabs with spaces in your diff? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/13868/#comment50306> This time needs to be converted now, right? Nanoseconds(stat.get()["throttled_time"]).secs() - Ben Mahler On Aug. 30, 2013, 12:30 a.m., Christina Delimitrou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13868/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2013, 12:30 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, and Jie > Yu. > > > Repository: mesos-git > > > Description > ------- > > Adding fields to record the cpu.stat statistics per cgroup. These include > nr_periods, nr_throttled and throttled_time. > > > Diffs > ----- > > include/mesos/mesos.proto bbf1d31 > src/slave/cgroups_isolator.cpp 676768e > src/slave/constants.cpp 8c74c00 > src/slave/monitor.cpp 8e1eb35 > src/slave/process_isolator.cpp fa80293 > > Diff: https://reviews.apache.org/r/13868/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Christina Delimitrou > >
