> On Aug. 29, 2013, 11:50 p.m., Ian Downes wrote: > > include/mesos/mesos.proto, line 286 > > <https://reviews.apache.org/r/13868/diff/1/?file=345284#file345284line286> > > > > why a double? - why not keep fixed point, say in ms rather than > > original ns.
I kept it in double to be consistent with the user/kernel cpu times above. I've added the specification that it's in secs though. - Christina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13868/#review25770 ----------------------------------------------------------- On Aug. 30, 2013, 12:30 a.m., Christina Delimitrou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13868/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2013, 12:30 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, and Jie > Yu. > > > Repository: mesos-git > > > Description > ------- > > Adding fields to record the cpu.stat statistics per cgroup. These include > nr_periods, nr_throttled and throttled_time. > > > Diffs > ----- > > include/mesos/mesos.proto bbf1d31 > src/slave/cgroups_isolator.cpp 676768e > src/slave/constants.cpp 8c74c00 > src/slave/monitor.cpp 8e1eb35 > src/slave/process_isolator.cpp fa80293 > > Diff: https://reviews.apache.org/r/13868/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Christina Delimitrou > >
