----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13868/#review25803 -----------------------------------------------------------
Ship it! Looks great! Just a minor whitespace nit. src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/13868/#comment50337> replace the tab here with spaces :) - Ben Mahler On Aug. 30, 2013, 7:04 p.m., Christina Delimitrou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13868/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2013, 7:04 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Adding fields to record the cpu.stat statistics per cgroup. These include > nr_periods, nr_throttled and throttled_time. > > > Diffs > ----- > > include/mesos/mesos.proto bbf1d31 > src/slave/cgroups_isolator.cpp 676768e > src/slave/constants.cpp 8c74c00 > src/slave/monitor.cpp 8e1eb35 > src/slave/process_isolator.cpp fa80293 > > Diff: https://reviews.apache.org/r/13868/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Christina Delimitrou > >
