> On Nov. 5, 2013, 8:13 p.m., Ross Allen wrote: > > I love the feature, but I wonder if we can accomplish the same > > functionality without adding D3? > > > > Bootstrap has progress bars[1] that are animated with CSS transitions. You > > can stack multiple colors inside the same bar and add tooltips on top of > > each one. The controllers would just need to set the width of the bars, and > > your browser would do the work of animating the width change. > > > > It would require very little new JS or styling. > > > > [1] http://getbootstrap.com/2.3.2/components.html#progress
Oh, It's really nice :-) This is much easier and simpler way!! I will try bootstrap's progress bar and update diff. - Shingo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/#review28219 ----------------------------------------------------------- On Nov. 4, 2013, 11:05 p.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15215/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 11:05 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod > Kone. > > > Repository: mesos-git > > > Description > ------- > > Support d3 bar charts for slaves, tasks, resources in mesos webui. > > - introduced d3 angular module and d3-bar angular directive. > - tipsy used for tooltipping on d3 chart because ui-bootstrap's tooltipping > doesn't work well with d3. > tipsy: https://gist.github.com/ilyabo/1373263 > - color scheme would be changed for better presentation. > > JIRA: https://issues.apache.org/jira/browse/MESOS-797 > > > Diffs > ----- > > src/webui/master/static/css/d3-bar.css PRE-CREATION > src/webui/master/static/css/tipsy.css PRE-CREATION > src/webui/master/static/home.html 4f9e2d9 > src/webui/master/static/index.html 47403d8 > src/webui/master/static/js/app.js b918799 > src/webui/master/static/js/controllers.js 0c930a2 > src/webui/master/static/js/d3.v.3.3.9.js PRE-CREATION > src/webui/master/static/js/d3.v.3.3.9.min.js PRE-CREATION > src/webui/master/static/js/jquery.tipsy.js PRE-CREATION > > Diff: https://reviews.apache.org/r/15215/diff/ > > > Testing > ------- > > testing on my laptop, single host deployment. > using mesos-execute, I confirmed the bar charts was updated. > screenshot is here: > https://twitter.com/everpeace/status/397320001725554689/photo/1 > > > Thanks, > > Shingo Omura > >
