----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/#review28465 -----------------------------------------------------------
src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/15215/#comment55269> $scope.state already exists. Can you reference that instead of adding this? src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/15215/#comment55268> $scope.total_cpus and $scope.total_mem are already set. - Ross Allen On Nov. 6, 2013, 1:27 a.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15215/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 1:27 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod > Kone. > > > Repository: mesos-git > > > Description > ------- > > Support d3 bar charts for slaves, tasks, resources in mesos webui. > > - introduced d3 angular module and d3-bar angular directive. > - tipsy used for tooltipping on d3 chart because ui-bootstrap's tooltipping > doesn't work well with d3. > tipsy: https://gist.github.com/ilyabo/1373263 > - color scheme would be changed for better presentation. > > JIRA: https://issues.apache.org/jira/browse/MESOS-797 > > > Diffs > ----- > > src/webui/master/static/home.html 4f9e2d9 > src/webui/master/static/js/controllers.js db015b2 > > Diff: https://reviews.apache.org/r/15215/diff/ > > > Testing > ------- > > testing on my laptop, single host deployment. > using mesos-execute, I confirmed the bar charts was updated. > screenshot is here: > https://twitter.com/everpeace/status/397320001725554689/photo/1 > > > File Attachments > ---------------- > > barcharts by bootstrap's progressbar > > https://reviews.apache.org/media/uploaded/files/2013/11/06/screenshots-barcharts-by-bootstrap-progressbar.png > > > Thanks, > > Shingo Omura > >
