----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/#review28843 -----------------------------------------------------------
src/webui/master/static/home.html <https://reviews.apache.org/r/15215/#comment55879> Mixing active tasks (Staged and Started) with completed tasks (all other states) gives an odd feeling of 100% since it will never be 100% once you have at least one completed task. Would it make more sense to split these into two bars with active and completed tasks? src/webui/master/static/home.html <https://reviews.apache.org/r/15215/#comment55877> Since the CPU and Memory bars are stacked on each other, they need labels to differentiate them otherwise you can't tell what they are without hovering. Maybe text labels above them? src/webui/master/static/home.html <https://reviews.apache.org/r/15215/#comment55878> Yellow should be for warnings or incorrect states, but idle resources aren't really a problem. Could idle resources be black or just not filled at all? - Ross Allen On Nov. 8, 2013, 5:16 a.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15215/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 5:16 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod > Kone. > > > Repository: mesos-git > > > Description > ------- > > Support d3 bar charts for slaves, tasks, resources in mesos webui. > > - introduced d3 angular module and d3-bar angular directive. > - tipsy used for tooltipping on d3 chart because ui-bootstrap's tooltipping > doesn't work well with d3. > tipsy: https://gist.github.com/ilyabo/1373263 > - color scheme would be changed for better presentation. > > JIRA: https://issues.apache.org/jira/browse/MESOS-797 > > > Diffs > ----- > > src/webui/master/static/home.html 4f9e2d9 > src/webui/master/static/js/app.js b918799 > src/webui/master/static/js/controllers.js db015b2 > > Diff: https://reviews.apache.org/r/15215/diff/ > > > Testing > ------- > > testing on my laptop, single host deployment. > using mesos-execute, I confirmed the bar charts was updated. > screenshot is here: > https://twitter.com/everpeace/status/397320001725554689/photo/1 > > > File Attachments > ---------------- > > barcharts by bootstrap's progressbar > > https://reviews.apache.org/media/uploaded/files/2013/11/06/screenshots-barcharts-by-bootstrap-progressbar.png > > > Thanks, > > Shingo Omura > >
