----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15542/#review29054 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/15542/#comment56134> Thanks for clarifying! Rather than offer two ways of doing it, let's mark the old one as deprecated so that we can eventually have frameworks only using this improved version. Or is there a reason to keep both versions indefinitely? How about we clean up the naming a little bit? ExecV seems to suggest too much about the implementation, what about s/ExecV/Command/ and s/args/arguments/ (we tend to avoid abbreviations): message Command { required string command = 1; repeated string arguments = 2; } ... required string value = 3; // Deprecated, please use command instead. optional Command command = 4; - Ben Mahler On Nov. 18, 2013, 1:31 a.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15542/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 1:31 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Offer an execvp like interface for running tasks. > > Review: https://reviews.apache.org/r/15542 > > > Diffs > ----- > > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/examples/python/test_framework.py > deca48e779ae099424fa73bb9a8ac5c419c5faf1 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/slave/process_isolator.cpp a6e9ed6a654972e8a51a9a033052e02ce44fe3e4 > > Diff: https://reviews.apache.org/r/15542/diff/ > > > Testing > ------- > > Ran Python test executor and `make check`. > > > Thanks, > > Jason Dusek > >
