> On Nov. 18, 2013, 8:01 p.m., Vinod Kone wrote: > > src/slave/process_isolator.cpp, line 236 > > <https://reviews.apache.org/r/15542/diff/3/?file=387247#file387247line236> > > > > Is std::copy async signal safe? Doesn't look like it from this list? > > > > > > https://www.securecoding.cert.org/confluence/display/seccode/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers > > > >
Just a heads-up: We're working on refactoring the whole isolator and modularizing the isolation and launching components. It's some time away from being ready so this execvp feature is sure to be committed first but I'll be sure to include it. We've ensured async signal safety by having almost nothing between the fork() and the exec() and precomputing anything in the parent before the fork(). - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15542/#review29064 ----------------------------------------------------------- On Nov. 18, 2013, 11:57 p.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15542/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 11:57 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Offer an execvp like interface for running tasks. > > Review: https://reviews.apache.org/r/15542 > > > Diffs > ----- > > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/examples/python/test_framework.py > deca48e779ae099424fa73bb9a8ac5c419c5faf1 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/slave/process_isolator.cpp a6e9ed6a654972e8a51a9a033052e02ce44fe3e4 > > Diff: https://reviews.apache.org/r/15542/diff/ > > > Testing > ------- > > Ran Python test executor and `make check`. > > > Thanks, > > Jason Dusek > >
