----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15542/#review29064 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/15542/#comment56141> Can you add documentation about what ExecV is used for? Also, while you are it, mind killing the trailing white space here? src/launcher/executor.cpp <https://reviews.apache.org/r/15542/#comment56143> I suspect this is not async signal safe? We have had issues in the past where we were trying to do too much C++ (e.g., ostringstream) between fork() and exec() resulting in dead locks. src/launcher/executor.cpp <https://reviews.apache.org/r/15542/#comment56144> Why not print this in the above loop? src/launcher/launcher.cpp <https://reviews.apache.org/r/15542/#comment56145> Ditto. Is this async signal safe? src/slave/process_isolator.cpp <https://reviews.apache.org/r/15542/#comment56146> Is std::copy async signal safe? Doesn't look like it from this list? https://www.securecoding.cert.org/confluence/display/seccode/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers - Vinod Kone On Nov. 18, 2013, 1:31 a.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15542/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 1:31 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Offer an execvp like interface for running tasks. > > Review: https://reviews.apache.org/r/15542 > > > Diffs > ----- > > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/examples/python/test_framework.py > deca48e779ae099424fa73bb9a8ac5c419c5faf1 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/slave/process_isolator.cpp a6e9ed6a654972e8a51a9a033052e02ce44fe3e4 > > Diff: https://reviews.apache.org/r/15542/diff/ > > > Testing > ------- > > Ran Python test executor and `make check`. > > > Thanks, > > Jason Dusek > >
