----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15778/#review29321 -----------------------------------------------------------
src/sched/sched.cpp <https://reviews.apache.org/r/15778/#comment56490> s/leader/leading master/ or s/leader/registered master/ ? src/sched/sched.cpp <https://reviews.apache.org/r/15778/#comment56491> Can you add a comment on why you need the if check. I presume this is because the driver itself can generate updates. src/sched/sched.cpp <https://reviews.apache.org/r/15778/#comment56492> why no changes here? src/sched/sched.cpp <https://reviews.apache.org/r/15778/#comment56493> Can you add a comment here on why you are doing the master check here? src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/15778/#comment56494> new line. src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/15778/#comment56507> Can you mention in the comment that you are spoofing the sender to be a random master? Also, mention that this should be dropped by the driver. src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/15778/#comment56508> Is this possible? - Vinod Kone On Nov. 22, 2013, 8:40 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15778/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 8:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-832 > https://issues.apache.org/jira/browse/MESOS-832 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-832 for additional context. > > > Diffs > ----- > > src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9 > src/tests/fault_tolerance_tests.cpp > 6cb5829119ed3e855740fb9331e4fb19c16d3629 > > Diff: https://reviews.apache.org/r/15778/diff/ > > > Testing > ------- > > Added a test and ran it with 20,000 iterations. > > > Thanks, > > Ben Mahler > >
