> On Nov. 25, 2013, 10:26 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, line 1833 > > <https://reviews.apache.org/r/15778/diff/1-2/?file=389853#file389853line1833> > > > > s/,/;,/ ?
fixed > On Nov. 25, 2013, 10:26 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, line 1835 > > <https://reviews.apache.org/r/15778/diff/1-2/?file=389853#file389853line1835> > > > > s/onto// thanks! > On Nov. 25, 2013, 10:26 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 378 > > <https://reviews.apache.org/r/15778/diff/1-2/?file=389852#file389852line378> > > > > s/leading/registered/ is probably more applicable? sorry, i missed it > > the last time. but i will leave it up to you. I see, hmm the wording is a bit tricky with "registered" since we'd want to say "the master we're registered with" as opposed to the "registered master", so I'll leave as leading. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15778/#review29400 ----------------------------------------------------------- On Nov. 23, 2013, 1:09 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15778/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2013, 1:09 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-832 > https://issues.apache.org/jira/browse/MESOS-832 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-832 for additional context. > > > Diffs > ----- > > src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9 > src/tests/fault_tolerance_tests.cpp > 6cb5829119ed3e855740fb9331e4fb19c16d3629 > > Diff: https://reviews.apache.org/r/15778/diff/ > > > Testing > ------- > > Added a test and ran it with 20,000 iterations. > > > Thanks, > > Ben Mahler > >
