> On Nov. 23, 2013, 12:34 a.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 676 > > <https://reviews.apache.org/r/15778/diff/1/?file=389852#file389852line676> > > > > why no changes here?
Framework messages are sent by the slave. > On Nov. 23, 2013, 12:34 a.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 698 > > <https://reviews.apache.org/r/15778/diff/1/?file=389852#file389852line698> > > > > Can you add a comment here on why you are doing the master check here? > > Vinod Kone wrote: > s/doing/not doing/ The master sends error messages during framework failover to terminate the old scheduler driver. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15778/#review29321 ----------------------------------------------------------- On Nov. 22, 2013, 8:40 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15778/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 8:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-832 > https://issues.apache.org/jira/browse/MESOS-832 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-832 for additional context. > > > Diffs > ----- > > src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9 > src/tests/fault_tolerance_tests.cpp > 6cb5829119ed3e855740fb9331e4fb19c16d3629 > > Diff: https://reviews.apache.org/r/15778/diff/ > > > Testing > ------- > > Added a test and ran it with 20,000 iterations. > > > Thanks, > > Ben Mahler > >
