-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15706/
-----------------------------------------------------------
(Updated Nov. 28, 2013, 8:52 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
- BenM's comments
- Killed GroupProcess::error because it's actually mostly useless since each
time error is set, it is followed by abort() which clears it...
- Added CONNECTED state to help determine whether non-retryable error/abort()
has happened (state transitions to CONNECTING during abort())
With these changes I think the Group logic is simpler now.
Bugs: MESOS-814
https://issues.apache.org/jira/browse/MESOS-814
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/tests/group_tests.cpp fb4c2f103ab7436b0fa2d6276c1ec1011a9405f0
src/zookeeper/group.hpp 04068e357cec95457d1f24c166d0b60f86d997d2
src/zookeeper/group.cpp 12c781b29f4300ca8a29660adc3f1e55e03d5d04
Diff: https://reviews.apache.org/r/15706/diff/
Testing (updated)
-------
make check & mesos-tests.sh
--gtest_filter=GroupTest*:ZooKeeperTest*:ZooKeeperMasterContenderDetectorTest*
with 100 iterations.
Added a test to exercise authenticate() and create() retries.
Thanks,
Jiang Yan Xu
