> On Dec. 3, 2013, 7:08 p.m., Ben Mahler wrote: > > src/zookeeper/group.cpp, line 472 > > <https://reviews.apache.org/r/15706/diff/6/?file=392957#file392957line472> > > > > Maybe you'll want this CHECK above where you call cache as well? > > Jiang Yan Xu wrote: > updated() is answering a ZK event at which time memberships can be Some() > or None(). It is set to None() at the first line in cache().
I'm referring to the call to cache() in watch(), do you want the same consistency check (CHECK(memberships.isNone())) there when the cache operation returns false? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15706/#review29666 ----------------------------------------------------------- On Dec. 3, 2013, 7:50 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15706/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 7:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-814 > https://issues.apache.org/jira/browse/MESOS-814 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/group_tests.cpp fb4c2f103ab7436b0fa2d6276c1ec1011a9405f0 > src/zookeeper/group.hpp 04068e357cec95457d1f24c166d0b60f86d997d2 > src/zookeeper/group.cpp 5218286bb6ab989ba16cead1483851cc8adba5ca > > Diff: https://reviews.apache.org/r/15706/diff/ > > > Testing > ------- > > make check & mesos-tests.sh > --gtest_filter=GroupTest*:ZooKeeperTest*:ZooKeeperMasterContenderDetectorTest* > with 100 iterations. > > Added a test to exercise authenticate() and create() retries. > > > Thanks, > > Jiang Yan Xu > >
