> On Nov. 26, 2013, 3:58 a.m., Ben Mahler wrote: > > src/tests/group_tests.cpp, lines 334-336 > > <https://reviews.apache.org/r/15706/diff/3/?file=390857#file390857line334> > > > > Is this guaranteed to cause retries? > > Jiang Yan Xu wrote: > Likely... and I have read logs to see the retries of authenticate() and > create() *always* get executed. > > This test is testing that code's robustness can tolerate many expirations > (one type of retryable errors that we can control) but with authenticate() > and create() not being called through dispatch() it is hard to control the > exact timing. I think high iteration without flakiness should be good proof.
If it's likely and not guaranteed, let's explicitly call out that this test is just attempting to probabilistically trigger the retries. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15706/#review29414 ----------------------------------------------------------- On Nov. 28, 2013, 8:52 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15706/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 8:52 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-814 > https://issues.apache.org/jira/browse/MESOS-814 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/group_tests.cpp fb4c2f103ab7436b0fa2d6276c1ec1011a9405f0 > src/zookeeper/group.hpp 04068e357cec95457d1f24c166d0b60f86d997d2 > src/zookeeper/group.cpp 12c781b29f4300ca8a29660adc3f1e55e03d5d04 > > Diff: https://reviews.apache.org/r/15706/diff/ > > > Testing > ------- > > make check & mesos-tests.sh > --gtest_filter=GroupTest*:ZooKeeperTest*:ZooKeeperMasterContenderDetectorTest* > with 100 iterations. > > Added a test to exercise authenticate() and create() retries. > > > Thanks, > > Jiang Yan Xu > >
