> On Jan. 15, 2014, 2:04 a.m., Benjamin Hindman wrote: > > src/slave/monitor.cpp, line 231 > > <https://reviews.apache.org/r/13605/diff/2/?file=422668#file422668line231> > > > > Can we clean this up at all? What about a function, which takes > > framework ID and executor info and returns a future which contains all of > > FrameworkID, ExecutorInfo, and ResourceStatistics (perhaps as a struct?) > > that is satisfied when the underlying future returned from the isolator is > > satisfied?
I've added a Usage struct that wraps these and a usage() call to do the wrapping. It's a little more code but the logic should be more straightforward. The collect() call could also make use of usage() to be more consistent, but the logic in _collect() becomes slightly more complex, so I opted against it. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13605/#review31842 ----------------------------------------------------------- On Jan. 15, 2014, 2:06 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13605/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 2:06 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This alters statistics.json to return instantaneous resource consumption > information. > > Previously, one could receive information that is stale by up to 5 seconds > (or the RESOURCE_MONITORING_INTERVAL). This allows one to build Top like > utilities using the monitoring endpoint, this is done by the subsequent > change in this chain of reviews. > > > Diffs > ----- > > src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 > src/slave/monitor.cpp a931c4f35a8793c66ee03de82f0e0a21b92f8ffa > src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253 > > Diff: https://reviews.apache.org/r/13605/diff/ > > > Testing > ------- > > Split the monitoring tests into two tests: > > 1. Tests that verify the periodic collection is working correctly. > 2. Tests that use the instantaneous statistics.json endpoint. > > > Thanks, > > Ben Mahler > >
