> On Jan. 21, 2014, 7:18 p.m., Benjamin Hindman wrote: > > src/slave/monitor.cpp, line 230 > > <https://reviews.apache.org/r/13605/diff/4/?file=425942#file425942line230> > > > > Seems like it would be nice to capture this to the log ...
Done! > On Jan. 21, 2014, 7:18 p.m., Benjamin Hindman wrote: > > src/slave/monitor.cpp, line 210 > > <https://reviews.apache.org/r/13605/diff/4/?file=425942#file425942line210> > > > > Alternatively you could have a 'list<Usage> usages' where each Usage > > has a Future<ResourceStatistics> and still do process::await on those > > futures but just pass in 'usages' rather than 'lambda::_1' for > > '__statistics' as you do now. Done! > On Jan. 21, 2014, 7:18 p.m., Benjamin Hindman wrote: > > src/slave/monitor.cpp, line 214 > > <https://reviews.apache.org/r/13605/diff/4/?file=425942#file425942line214> > > > > Is there any reason to eventually make batch usage calls to the > > Isolator/Containerizer? Maybe a TODO that motivates that here? Added a TODO. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13605/#review32396 ----------------------------------------------------------- On Jan. 17, 2014, 4:04 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13605/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 4:04 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This alters statistics.json to return instantaneous resource consumption > information. > > Previously, one could receive information that is stale by up to 5 seconds > (or the RESOURCE_MONITORING_INTERVAL). This allows one to build Top like > utilities using the monitoring endpoint, this is done by the subsequent > change in this chain of reviews. > > > Diffs > ----- > > src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 > src/slave/monitor.cpp a931c4f35a8793c66ee03de82f0e0a21b92f8ffa > src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253 > > Diff: https://reviews.apache.org/r/13605/diff/ > > > Testing > ------- > > Split the monitoring tests into two tests: > > 1. Tests that verify the periodic collection is working correctly. > 2. Tests that use the instantaneous statistics.json endpoint. > > > Thanks, > > Ben Mahler > >
