-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13605/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 4:04 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Code cleanup per benh review.


Repository: mesos-git


Description
-------

This alters statistics.json to return instantaneous resource consumption 
information.

Previously, one could receive information that is stale by up to 5 seconds (or 
the RESOURCE_MONITORING_INTERVAL). This allows one to build Top like utilities 
using the monitoring endpoint, this is done by the subsequent change in this 
chain of reviews.


Diffs (updated)
-----

  src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
  src/slave/monitor.cpp a931c4f35a8793c66ee03de82f0e0a21b92f8ffa 
  src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253 

Diff: https://reviews.apache.org/r/13605/diff/


Testing
-------

Split the monitoring tests into two tests:

1. Tests that verify the periodic collection is working correctly.
2. Tests that use the instantaneous statistics.json endpoint.


Thanks,

Ben Mahler

Reply via email to