> On Jan. 29, 2014, 3:26 a.m., Benjamin Hindman wrote: > > src/master/http.cpp, line 363 > > <https://reviews.apache.org/r/17255/diff/1/?file=436254#file436254line363> > > > > Do you want to check for 'jsonp'? > > Charlie Carson wrote: > I'm not opposed, but not 100% it's useful either. jsonp is typically so > that you can invoke a local call back when the response comes back, right? > ex: > > <script type="application/javascript" > src="http://server2.example.com/Users/1234?jsonp=parseResponse";> > </script> > > would invoke parseResponse w/ the result of the get to the resource. > > the reason i'm not sure it makes sense is that this upload is a post, > which you can't do with a script tag. > > OTOH, I might be ignorant of some other valid use cases. dropping for > now - happy to reopen :-)
Makes sense to ignore for a POST! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/#review33087 ----------------------------------------------------------- On Jan. 30, 2014, 10:13 p.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17255/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 10:13 p.m.) > > > Review request for mesos, Benjamin Hindman and Jeff Currier. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-880 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-880 > > > Repository: mesos-git > > > Description > ------- > > Add observe endpoint to master. > > This changes adds a new HTTP endpoint of observe to master. > This allows clients to report health via an HTTP POST. > Values are: > MONITOR = Monitor for which health is being reported. > HOSTS = Comma seperated list of hosts. > LEVEL = OK for healthy, anything else for unhealthy. > > This also contains a small fix to alphabetize the existing > endpoints / help strings. > > SEE: https://issues.apache.org/jira/browse/MESOS-880 > > Review: https://reviews.apache.org/r/17255 > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c > src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b > src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be > src/tests/health_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17255/diff/ > > > Testing > ------- > > make check > added unit tests in a new health_test.cpp file > > > Thanks, > > Charlie Carson > >
