----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/#review34161 -----------------------------------------------------------
Ship it! Nice test. src/master/http.cpp <https://reviews.apache.org/r/17255/#comment64173> We always use braces for if/for/while loops. if () { } src/master/http.cpp <https://reviews.apache.org/r/17255/#comment64174> ditto. src/master/http.cpp <https://reviews.apache.org/r/17255/#comment64175> ditto. src/master/http.cpp <https://reviews.apache.org/r/17255/#comment64176> s/either/of/ ? src/tests/repair_tests.cpp <https://reviews.apache.org/r/17255/#comment64177> s/r/response/ src/tests/repair_tests.cpp <https://reviews.apache.org/r/17255/#comment64178> s/o/object/ src/tests/repair_tests.cpp <https://reviews.apache.org/r/17255/#comment64179> How about using a ternary operator for conciseness? src/tests/repair_tests.cpp <https://reviews.apache.org/r/17255/#comment64180> s/!ok/level != OK/ ? - Vinod Kone On Feb. 11, 2014, 12:10 a.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17255/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 12:10 a.m.) > > > Review request for mesos, Benjamin Hindman and Jeff Currier. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-880 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-880 > > > Repository: mesos-git > > > Description > ------- > > Add observe endpoint to master. > > This changes adds a new HTTP endpoint of observe to master. > This allows clients to report health via an HTTP POST. > Values are: > MONITOR = Monitor for which health is being reported. > HOSTS = Comma seperated list of hosts. > LEVEL = OK for healthy, anything else for unhealthy. > > This also contains a small fix to alphabetize the existing > endpoints / help strings. > > SEE: https://issues.apache.org/jira/browse/MESOS-880 > > Review: https://reviews.apache.org/r/17255 > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c > src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b > src/master/master.cpp 241b0069902cd125fdd933096ddd7e1c841d1559 > src/tests/repair_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17255/diff/ > > > Testing > ------- > > make check > added unit tests in a new repair_test.cpp file > > > Thanks, > > Charlie Carson > >
