> On March 20, 2014, 6:45 p.m., Dominic Hamon wrote:
> > src/master/master.cpp, line 551
> > <https://reviews.apache.org/r/17255/diff/4/?file=484418#file484418line551>
> >
> >     Could you follow up with a fix for this? It should be bound to 
> > Http::stats, not roles.

opened https://issues.apache.org/jira/browse/MESOS-1129 to track this since the 
review is closed and code is in


- Charlie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17255/#review37941
-----------------------------------------------------------


On Feb. 13, 2014, 6:55 p.m., Charlie Carson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17255/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 6:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jeff Currier.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-880
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-880
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add observe endpoint to master.
> 
>     This changes adds a new HTTP endpoint of observe to master.
>     This allows clients to report health via an HTTP POST.
>     Values are:
>       MONITOR = Monitor for which health is being reported.
>       HOSTS = Comma seperated list of hosts.
>       LEVEL = OK for healthy, anything else for unhealthy.
> 
>     This also contains a small fix to alphabetize the existing
>     endpoints / help strings.
> 
>     SEE:  https://issues.apache.org/jira/browse/MESOS-880
> 
>     Review: https://reviews.apache.org/r/17255
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am aa8bb2b492e4d37b14db294f48c074e631143b68 
>   src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
>   src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba 
>   src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c 
>   src/tests/repair_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17255/diff/
> 
> 
> Testing
> -------
> 
> make check
> added unit tests in a new repair_test.cpp file
> 
> 
> Thanks,
> 
> Charlie Carson
> 
>

Reply via email to