----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18138/#review34534 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Feb. 14, 2014, 6:58 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18138/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 6:58 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-979 > https://issues.apache.org/jira/browse/MESOS-979 > > > Repository: mesos-git > > > Description > ------- > > Related to MESOS-979, the tasks.json endpoint would sporadically cause the > master process to SEGFAULT. The code failed during the subsequent sort > (after gathering running and completed tasks) deferencing garbage pointer > values. The issue turns out to be an issue with std::sort and strict weak- > ordering. Descending order (which was default) was implemented as !ascending() > which is not a strict greather-than equal. This patch expands the descending > implementation and reenables endpoint. > > > Diffs > ----- > > src/master/http.cpp 966eed6 > src/master/master.cpp a4e1b1f > > Diff: https://reviews.apache.org/r/18138/diff/ > > > Testing > ------- > > make check and functional testing; can't trigger earlier repro steps for > segfault. > > > Thanks, > > Niklas Nielsen > >
