> On Feb. 18, 2014, 11:36 a.m., Vinod Kone wrote: > > Niklas, can you commit this? > > > > Also, I don't think I understand what the issue with sort and weak ordering > > is. Mind expanding on it a bit or pointing me to a reference?
You bet. This is the best explanation I could find on the issue: http://stackoverflow.com/questions/16535882/stdsort-with-equal-elements-gives-segmentation-fault The strict weak ordering requirement is mentioned in http://www.cplusplus.com/reference/algorithm/sort/ and explained here: http://www.sgi.com/tech/stl/StrictWeakOrdering.html - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18138/#review34759 ----------------------------------------------------------- On Feb. 18, 2014, 8:43 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18138/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 8:43 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-979 > https://issues.apache.org/jira/browse/MESOS-979 > > > Repository: mesos-git > > > Description > ------- > > Related to MESOS-979, the tasks.json endpoint would sporadically cause the > master process to SEGFAULT. The code failed during the subsequent sort > (after gathering running and completed tasks) deferencing garbage pointer > values. The issue turns out to be an issue with std::sort and strict weak- > ordering. Descending order (which was default) was implemented as !ascending() > which is not a strict greather-than equal. This patch expands the descending > implementation and reenables endpoint. > > > Diffs > ----- > > src/master/http.cpp 6aeb257 > src/master/master.cpp f4f5e04 > > Diff: https://reviews.apache.org/r/18138/diff/ > > > Testing > ------- > > make check and functional testing; can't trigger earlier repro steps for > segfault. > > > Thanks, > > Niklas Nielsen > >
