-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18138/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 11:30 a.m.)
Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
Changes
-------
I managed to trigger the bug again and turned out to be related to Adam's
concern about the semantics when both lhs and rhs is empty.
This patch should handle issue.
Bugs: MESOS-979
https://issues.apache.org/jira/browse/MESOS-979
Repository: mesos-git
Description
-------
Related to MESOS-979, the tasks.json endpoint would sporadically cause the
master process to SEGFAULT. The code failed during the subsequent sort
(after gathering running and completed tasks) deferencing garbage pointer
values. The issue turns out to be an issue with std::sort and strict weak-
ordering. Descending order (which was default) was implemented as !ascending()
which is not a strict greather-than equal. This patch expands the descending
implementation and reenables endpoint.
Diffs (updated)
-----
src/master/http.cpp 6aeb257
src/master/master.cpp f4f5e04
Diff: https://reviews.apache.org/r/18138/diff/
Testing
-------
make check and functional testing; can't trigger earlier repro steps for
segfault.
Thanks,
Niklas Nielsen
