----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18368/#review35185 -----------------------------------------------------------
src/log/recover.cpp <https://reviews.apache.org/r/18368/#comment65618> Can this be done in one line? Ie, set an initial set in the IntervalSet constructor: IntervalSet<uint64_t> positions(Bound::closed(lowestBeginPosition.get()), Bound::closed(highestEndPosition.get())); src/log/replica.cpp <https://reviews.apache.org/r/18368/#comment65620> this could be simplified: return unlearned.contains(position) || holes.contains(position); src/log/replica.cpp <https://reviews.apache.org/r/18368/#comment65622> Is this a valid condition? ie, should we CHECK_GE(from, to) instead? src/log/replica.cpp <https://reviews.apache.org/r/18368/#comment65623> I wonder if these operations would be clearer as named methods 'union' or 'intersection' - Dominic Hamon On Feb. 21, 2014, 11:19 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18368/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 11:19 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/catchup.hpp 45dc016 > src/log/catchup.cpp bcad278 > src/log/coordinator.cpp 96ab121 > src/log/recover.cpp 1841f1f > src/log/replica.hpp 08ddcb1 > src/log/replica.cpp 746d6c3 > src/log/storage.hpp c0eba1b > src/tests/log_tests.cpp 2613e41 > > Diff: https://reviews.apache.org/r/18368/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
