> On Feb. 21, 2014, 7:30 p.m., Dominic Hamon wrote: > > src/log/replica.cpp, line 265 > > <https://reviews.apache.org/r/18368/diff/1/?file=500260#file500260line265> > > > > Is this a valid condition? ie, should we CHECK_GE(from, to) instead?
This function is exposed by Replica. Added a LOG(ERROR) here. > On Feb. 21, 2014, 7:30 p.m., Dominic Hamon wrote: > > src/log/replica.cpp, line 283 > > <https://reviews.apache.org/r/18368/diff/1/?file=500260#file500260line283> > > > > I wonder if these operations would be clearer as named methods 'union' > > or 'intersection' I prefer "&=" because it's more consistent with "-=" and "+=" above:) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18368/#review35185 ----------------------------------------------------------- On Feb. 21, 2014, 7:19 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18368/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 7:19 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/catchup.hpp 45dc016 > src/log/catchup.cpp bcad278 > src/log/coordinator.cpp 96ab121 > src/log/recover.cpp 1841f1f > src/log/replica.hpp 08ddcb1 > src/log/replica.cpp 746d6c3 > src/log/storage.hpp c0eba1b > src/tests/log_tests.cpp 2613e41 > > Diff: https://reviews.apache.org/r/18368/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
