----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18368/#review36198 -----------------------------------------------------------
src/log/catchup.cpp <https://reviews.apache.org/r/18368/#comment67123> Why did you change this name? Was the signature not enough? src/log/catchup.cpp <https://reviews.apache.org/r/18368/#comment67124> current == positions.upper() ? Seems like we should really make sure it's not greater! Maybe a CHECK? src/log/catchup.cpp <https://reviews.apache.org/r/18368/#comment67127> Do we need a Promise? Looks like we could just use a 'Future<Nothing> f = Nothing()' unless you want to delay starting the chain until all the callbacks were registered? src/log/replica.cpp <https://reviews.apache.org/r/18368/#comment67126> Kill this? src/log/replica.cpp <https://reviews.apache.org/r/18368/#comment67125> If this is really an error, why are we returning an empty interval set? - Ben Mahler On March 1, 2014, 7:34 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18368/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 7:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/catchup.hpp 45dc016 > src/log/catchup.cpp dae4619 > src/log/coordinator.cpp 6bfff1e > src/log/recover.cpp 3403b47 > src/log/replica.hpp 08ddcb1 > src/log/replica.cpp 1f1a945 > src/log/storage.hpp c0eba1b > src/tests/log_tests.cpp 0e2485f > > Diff: https://reviews.apache.org/r/18368/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
