----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18403/#review37157 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/18403/#comment68559> return false here too? src/slave/slave.cpp <https://reviews.apache.org/r/18403/#comment68557> This error message is confusing/inaccurate. The problem is that the executor is already known (executors does contain executorId). Somebody's trying to launch a task for an executor that's already running on that slave. Can you reword the error to clarify what the problem is? src/slave/slave.cpp <https://reviews.apache.org/r/18403/#comment68558> Initializing resources in the constructor is great, but perhaps Executor::finalize(ExecInfo) should set resources = info.resources(); Then you wouldn't even need to set resources in the other constructor, since the call to finalize would do it for you. Or maybe finalize needs to do a MergeFrom, in case the TaskInfo call-path already set resources before the executor could finish launching. - Adam B On March 13, 2014, 7:42 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18403/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 7:42 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes, > Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-922 > https://issues.apache.org/jira/browse/MESOS-922 > > > Repository: mesos-git > > > Description > ------- > > This patch delegates the choice of executor to the containerizer by removing > executorInfo dependencies up until Containerizer::launch(). > Containerizer::launch() now returns a future to the executor info that is > being run and the slave creates the corresponding executor structure when > launch completes. > This means message handling from the running executor to the slave in the > interim where the executor structure has not created, need to be enqueued > until executor is ready. So far, registerExecutor() and reregisterExecutor() > has been split into two continuations to deal with this issue. > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp d9ae326 > src/slave/containerizer/mesos_containerizer.hpp ee1fd30 > src/slave/containerizer/mesos_containerizer.cpp c1a3e0f > src/slave/http.cpp 594032d > src/slave/slave.hpp 01b80df > src/slave/slave.cpp 6abb95d > src/tests/containerizer.hpp 5686398 > src/tests/containerizer.cpp bfb9341 > > Diff: https://reviews.apache.org/r/18403/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
