----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18386/#review36021 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/18386/#comment66812> What about s/runOption/run/ and just using run.get() in all the code below? It doesn't look like that will introduce any significant clutter. We'll also avoid including type information in variable names (we can see runOption is an Option from the type so it's a bit redundant). - Ben Mahler On Feb. 28, 2014, 6:47 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18386/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 6:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db > src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426 > src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4 > src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426 > src/slave/slave.cpp 4f5349ba75da0bca43c88d33bb663cfa167cbdd3 > > Diff: https://reviews.apache.org/r/18386/diff/ > > > Testing > ------- > > make check > > 'grep' for cases where Options are reassigned after references are taken. > > > Thanks, > > Dominic Hamon > >
