> On March 3, 2014, 10:04 p.m., Ben Mahler wrote: > > How are you testing these patches? Have you run the tests? > > > > I'm seeing a test failure, and it looks like status_update_manager.cpp:223 > > has the same issue we discussed earlier.
Note that to run any cgroup related tests, you must run the tests as the root user. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18386/#review36043 ----------------------------------------------------------- On March 3, 2014, 9:13 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18386/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 9:13 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db > src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426 > src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4 > src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426 > src/slave/slave.cpp 4f5349ba75da0bca43c88d33bb663cfa167cbdd3 > > Diff: https://reviews.apache.org/r/18386/diff/ > > > Testing > ------- > > make check > > 'grep' for cases where Options are reassigned after references are taken. > > > Thanks, > > Dominic Hamon > >
