----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18386/#review36691 -----------------------------------------------------------
src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/18386/#comment67747> ditto here src/slave/status_update_manager.cpp <https://reviews.apache.org/r/18386/#comment67746> Why don't we do the same update here as we did in slave.cpp? That is, we can pull out the option, CHECK_SOME and just use run.get() rather than needing the temporary '_run' variable. - Ben Mahler On March 5, 2014, 12:31 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18386/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 12:31 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db > src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426 > src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4 > src/sched/sched.cpp 00f6307e539d3176185266095c2424a58ea1d426 > src/slave/containerizer/mesos_containerizer.cpp > 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5 > src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848 > src/slave/status_update_manager.cpp > 9db53e8b2a6440b7eebe3bc61912b170bde7a473 > > Diff: https://reviews.apache.org/r/18386/diff/ > > > Testing > ------- > > make check > > 'grep' for cases where Options are reassigned after references are taken. > > > Thanks, > > Dominic Hamon > >
