> On March 3, 2014, 12:41 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 26-27 > > <https://reviews.apache.org/r/18443/diff/1/?file=502836#file502836line26> > > > > Can you revert back to <> includes per the other discussion?
i will, but this can introduce a bug should process ever be installed on someone's machine. > On March 3, 2014, 12:41 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 92-93 > > <https://reviews.apache.org/r/18443/diff/1/?file=502836#file502836line92> > > > > Why? We intentionally added Failure as syntactic sugar. :) multiple ways to do the same thing belie a poor API. There should be one way to create a failure. As it says "Consider..." :) > On March 3, 2014, 12:41 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 544-545 > > <https://reviews.apache.org/r/18443/diff/1/?file=502836#file502836line544> > > > > Why this TODO? Failure is used to implicitly construct a Future, the > > copy occurring from the need to store the failure message inside Future. > > Which copy would be eliminated through an accessor? I thought someone might be accessing a Failure directly and copying out the message string. Of course, even better would be to remove this helper and just keep the explicit factory method. :) - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18443/#review36025 ----------------------------------------------------------- On March 3, 2014, 1:23 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18443/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 1:23 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > e45f4f79faeefbffc28d855d2f74e8df69099f18 > 3rdparty/libprocess/src/tests/http_tests.cpp > 779c30b235506453a68f7a089dd4438e540fce5a > > Diff: https://reviews.apache.org/r/18443/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
