> On March 4, 2014, 10:49 a.m., Ben Mahler wrote: > > Any updates to libprocess or Mesos needed here? > > Dominic Hamon wrote: > this is libprocess. no stout or mesos changes. > > Ben Mahler wrote: > Great! stout can't use anything from libprocess anyway :) > > Ben Mahler wrote: > Looks like a change is indeed required: > > ../../src/log/log.cpp: In member function 'void > mesos::internal::log::LogProcess::_recover()': > ../../src/log/log.cpp:336: error: passing 'const > process::Owned<mesos::internal::log::Replica>' as 'this' argument of > 'process::Shared<T> process::Owned<T>::share() [with T = > mesos::internal::log::Replica]' discards qualifiers
you're right - 18445. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18443/#review36135 ----------------------------------------------------------- On March 4, 2014, 10:33 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18443/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 10:33 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > e45f4f79faeefbffc28d855d2f74e8df69099f18 > 3rdparty/libprocess/src/tests/http_tests.cpp > 779c30b235506453a68f7a089dd4438e540fce5a > > Diff: https://reviews.apache.org/r/18443/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
