----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18443/#review36082 -----------------------------------------------------------
3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/18443/#comment66985> Can you use ASSERT_SOME_EQ here? ASSERT_SOME_EQ("chunked", future.get().headers.get("Transfer-Encoding")); These three should really be EXPECTs, but oh well. - Ben Mahler On March 3, 2014, 10:31 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18443/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 10:31 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > e45f4f79faeefbffc28d855d2f74e8df69099f18 > 3rdparty/libprocess/src/tests/http_tests.cpp > 779c30b235506453a68f7a089dd4438e540fce5a > > Diff: https://reviews.apache.org/r/18443/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
