----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18722/#review36319 -----------------------------------------------------------
The same check exists in libprocess/configure.ac. Is there a followup patch coming because otherwise it seems like this is insufficient for fixing the gcc 4.4 issue (or there is more issues at stake here). - Benjamin Hindman On March 4, 2014, 1:36 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18722/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 1:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-750 > https://issues.apache.org/jira/browse/MESOS-750 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > gtest's tr1::tuple conficts with std::tr1::tuple for gcc-4.4. However, we use > tuple throughout mesos so we assume tr1::tuple or tuple is available. As > such, we don't need gtest to define one. > > > Diffs > ----- > > configure.ac a84b9609e39dd9b76e293e650e076be359a719db > > Diff: https://reviews.apache.org/r/18722/diff/ > > > Testing > ------- > > export CXX=g++-4.4; export CC=gcc-4.4; ./bootstrap && cd build && > ../configure --with-cxx11 && make check > export CXX=g++-4.4; export CC=gcc-4.4; ./bootstrap && cd build && > ../configure && make check > > > Thanks, > > Dominic Hamon > >
