> On March 5, 2014, 5:18 p.m., Benjamin Hindman wrote: > > The same check exists in libprocess/configure.ac. Is there a followup patch > > coming because otherwise it seems like this is insufficient for fixing the > > gcc 4.4 issue (or there is more issues at stake here). > > Vinod Kone wrote: > i wonder how they compiled on gcc 4.4 then?
i guess the process tests don't use tuple, or process doesn't, so there's no mismatch. i'll remove the stanza anyway. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18722/#review36319 ----------------------------------------------------------- On March 3, 2014, 5:36 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18722/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 5:36 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-750 > https://issues.apache.org/jira/browse/MESOS-750 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > gtest's tr1::tuple conficts with std::tr1::tuple for gcc-4.4. However, we use > tuple throughout mesos so we assume tr1::tuple or tuple is available. As > such, we don't need gtest to define one. > > > Diffs > ----- > > configure.ac a84b9609e39dd9b76e293e650e076be359a719db > > Diff: https://reviews.apache.org/r/18722/diff/ > > > Testing > ------- > > export CXX=g++-4.4; export CC=gcc-4.4; ./bootstrap && cd build && > ../configure --with-cxx11 && make check > export CXX=g++-4.4; export CC=gcc-4.4; ./bootstrap && cd build && > ../configure && make check > > > Thanks, > > Dominic Hamon > >
